Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tremor ci inclusion #2334

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Tremor ci inclusion #2334

merged 1 commit into from
Jun 23, 2023

Conversation

Licenser
Copy link
Member

Pull request

Description

  • fix another dead link in axiom
  • improve tests for doc generation so we can't make dead links any more

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

-/-

darach
darach previously approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 23, 2023 •
edited
Loading

Codecov Report

Merging #2334 (931309f) into main (39789f5) will increase coverage by 2.32%.
The diff coverage is n/a.

❗ Current head 931309f differs from pull request most recent head cd20515. Consider uploading reports for the commit cd20515 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2334      +/-   ##
==========================================
+ Coverage   88.78%   91.10%   +2.32%     
==========================================
  Files         275      275              
  Lines       58211    58211              
==========================================
+ Hits        51681    53034    +1353     
+ Misses       6530     5177    -1353
Flag Coverage Δ
unittests 91.10% <ø> (+2.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 57 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39789f5...cd20515. Read the comment docs.

@Licenser Licenser force-pushed the tremor-ci-inclusion branch 2 times, most recently from 931309f to 16d2fa0 Compare June 23, 2023 12:14
@Licenser Licenser enabled auto-merge (rebase) June 23, 2023 12:31
darach
darach approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Licenser Licenser merged commit f008c7f into main Jun 23, 2023
@Licenser Licenser deleted the tremor-ci-inclusion branch June 23, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darach darach darach approved these changes

@mfelsche mfelsche Awaiting requested review from mfelsche mfelsche is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Licenser @darach